Repository navigation
Deduplicate quality_funcs f1/acc against metrics.py - #615
Merged
Merged
Conversation
quality_funcs.py reimplemented the tp/tn/fp/fn and precision/recall arithmetic already implemented by metrics.py's F1/Accuracy classes. f1() and acc() now delegate to those classes instead of duplicating the math. Prunes the corresponding Improvements.md item and logs the change in CHANGELOG.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xuv1tiWYdtxTf2jhrSPWVa
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quality_funcs.f1/accreimplemented the tp/tn/fp/fn and precision/recallarithmetic already implemented by
metrics.py'sF1/Accuracyclasses.Both now delegate to those classes instead of duplicating the math.
Improvements.md(§2 Code duplication).CHANGELOG.mdentry.Test plan
pytest tests/test_metrics.pypassesruff check ontolearn/learners --exclude ontolearn/learners/spell_kit --line-length=200passesf1/accproduce identical results to the prior implementation on a hand-computed tp/tn/fp/fn case, including the zero-division edge case🤖 Generated with Claude Code
https://claude.ai/code/session_01Xuv1tiWYdtxTf2jhrSPWVa